Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Upgrade React #32288

Merged
merged 10 commits into from
Jan 29, 2025
Merged

chore: Upgrade React #32288

merged 10 commits into from
Jan 29, 2025

Conversation

tassoevan
Copy link
Contributor

@tassoevan tassoevan commented Apr 22, 2024 •
edited by jira bot
Loading

Proposed changes (including videos or screenshots)

It upgrades React to major version 18.

Issue(s)

ARCH-1285

Steps to test or reproduce

Further comments

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 22, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: bafe403

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dionisio-bot dionisio-bot
Copy link
Contributor

dionisio-bot bot commented Apr 22, 2024 •
edited
Loading

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

@tassoevan tassoevan force-pushed the refactor/react-18 branch 5 times, most recently from ff55e00 to f566a7d Compare May 2, 2024 19:48
@tassoevan tassoevan force-pushed the refactor/react-18 branch 3 times, most recently from 9640aed to 601b4d2 Compare May 14, 2024 17:14
@codecov Codecov
Copy link

codecov bot commented May 14, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 59.18%. Comparing base (d222467) to head (bafe403).
Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32288      +/-   ##
===========================================
- Coverage    59.18%   59.18%   -0.01%     
===========================================
  Files         2822     2822              
  Lines        68097    68070      -27     
  Branches     15144    15136       -8     
===========================================
- Hits         40300    40284      -16     
+ Misses       24966    24956      -10     
+ Partials      2831     2830       -1
Flag Coverage Δ
unit 75.00% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@tassoevan tassoevan force-pushed the refactor/react-18 branch from 601b4d2 to 0e18f81 Compare May 14, 2024 21:56
@dougfabris dougfabris changed the title refactor/react-18 refactor: React v18 May 15, 2024
@dougfabris dougfabris added this to the 7.0 milestone May 15, 2024
@dougfabris dougfabris changed the title refactor: React v18 refactor: Upgrade react to v18 May 15, 2024
@tassoevan tassoevan force-pushed the refactor/react-18 branch 2 times, most recently from 38176a2 to 83cd480 Compare May 17, 2024 02:07
@tassoevan tassoevan force-pushed the refactor/react-18 branch from 83cd480 to 2e4e467 Compare May 25, 2024 03:47
@tassoevan tassoevan force-pushed the refactor/react-18 branch 4 times, most recently from d076071 to 65fd20a Compare July 4, 2024 15:32
@tassoevan tassoevan force-pushed the refactor/react-18 branch 2 times, most recently from 7be23ca to bacc190 Compare July 25, 2024 04:09
@tassoevan tassoevan force-pushed the refactor/react-18 branch 2 times, most recently from 1d6564c to bc08f57 Compare August 13, 2024 17:56
@tassoevan tassoevan force-pushed the refactor/react-18 branch 9 times, most recently from 9f89df1 to ce37eb3 Compare January 28, 2025 21:15
@tassoevan tassoevan marked this pull request as ready for review January 28, 2025 22:50
@tassoevan tassoevan requested review from a team as code owners January 28, 2025 22:50
@ggazzo ggazzo added the stat: QA assured Means it has been tested and approved by a company insider label Jan 28, 2025
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Jan 28, 2025
@ggazzo ggazzo merged commit 8e2c989 into develop Jan 29, 2025
53 checks passed
@ggazzo ggazzo deleted the refactor/react-18 branch January 29, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabriellsh gabriellsh gabriellsh approved these changes

@ggazzo ggazzo ggazzo approved these changes

Assignees
No one assigned
Labels
stat: QA assured Means it has been tested and approved by a company insider stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@tassoevan @ggazzo @gabriellsh @scuciatto @dougfabris